chore(ci): never download chromium in CI MONGOSH-1942 #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out to be just unnecessary, according to trying this out in a patch build.
Anemy
approved these changes
Dec 10, 2024
addaleax
added a commit
that referenced
this pull request
Jan 6, 2025
This reverts commit 5f5ea25. We do actually need this in macOS CI, this just happened to work a lot of the time because macOS hosts are static hosts and apparently an already-installed chromium persists on those. In order to keep things simple and keep CI green, let's just revert this for now.
addaleax
added a commit
that referenced
this pull request
Jan 8, 2025
#2311) This reverts commit 5f5ea25. We do actually need this in macOS CI, this just happened to work a lot of the time because macOS hosts are static hosts and apparently an already-installed chromium persists on those. In order to keep things simple and keep CI green, let's just revert this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be just unnecessary, at least according to trying this out in a patch build.